[webkit-reviews] review denied: [Bug 61942] [EFL] Add ImageDiff implementation. : [Attachment 95779] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Leandro Pereira
<leandro at profusion.mobi>'s request for review:
Bug 61942: [EFL] Add ImageDiff implementation.
https://bugs.webkit.org/show_bug.cgi?id=61942

Attachment 95779: Patch
https://bugs.webkit.org/attachment.cgi?id=95779&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95779&action=review

Same troubles.	We're 2011, not 1980.  This code doesn't need to compile on my
old DEC.

> Tools/DumpRenderTree/efl/ImageDiff.cpp:144
> +    else if (getenv("TEMP"))

Do we need to release returns from getenv?

> Tools/DumpRenderTree/efl/ImageDiff.cpp:165
> +    int tempImageFd;

Sigh.