[webkit-reviews] review granted: [Bug 12894] animation event handling broken: focusin : [Attachment 96764] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 10 11:58:38 PDT 2011
Nikolas Zimmermann <zimmermann at kde.org> has granted Rob Buis
<rwlbuis at gmail.com>'s request for review:
Bug 12894: animation event handling broken: focusin
https://bugs.webkit.org/show_bug.cgi?id=12894
Attachment 96764: Patch
https://bugs.webkit.org/attachment.cgi?id=96764&action=review
------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96764&action=review
Looks good to me, r=me!.
> Source/WebCore/svg/SVGStyledElement.cpp:515
> + Element* eventTarget = const_cast<SVGStyledElement *>(this);
> + return eventTarget->hasEventListeners(eventNames().focusinEvent) ||
eventTarget->hasEventListeners(eventNames().focusoutEvent);
A pity _has_EventListeners is non-const, anyhow remove the whitespace between
the star and Element in the const_cast please.
More information about the webkit-reviews
mailing list