[webkit-reviews] review granted: [Bug 62411] REGRESSION: End of apple.com video in full-screen mode leads to unusable page. : [Attachment 96659] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 62411: REGRESSION: End of apple.com video in full-screen mode leads to
unusable page.
https://bugs.webkit.org/show_bug.cgi?id=62411

Attachment 96659: Patch
https://bugs.webkit.org/attachment.cgi?id=96659&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=96659&action=review

> Source/WebCore/rendering/RenderFullScreen.cpp:47
> +    virtual ~RenderFullScreenPlaceholder() { }

There’s no need for you to define this explicitly.

> Source/WebCore/rendering/RenderFullScreen.cpp:48
> +    virtual bool isRenderFullScreenPlaceholder() const { return true; }

This could be private.

>> Source/WebCore/rendering/RenderFullScreen.cpp:49
>> +	virtual void destroy() {
> 
> Place brace on its own line for function definitions.  [whitespace/braces]
[4]

I think this could be private. I think it would be better style to not make
this inline.

> Source/WebCore/rendering/RenderFullScreen.cpp:53
> +    RenderFullScreen* m_owner;

This could be private.