[webkit-reviews] review granted: [Bug 62441] Add glyph table to SVGFontElement mapping between SVGGlyph <-> Glyph : [Attachment 96715] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 10 08:54:08 PDT 2011


Rob Buis <rwlbuis at gmail.com> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 62441: Add glyph table to SVGFontElement mapping between SVGGlyph <-> Glyph
https://bugs.webkit.org/show_bug.cgi?id=62441

Attachment 96715: Patch
https://bugs.webkit.org/attachment.cgi?id=96715&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=96715&action=review

LGTM

> Source/WebCore/svg/SVGGlyphMap.h:53
> +    void add(const String& string, const SVGGlyph& glyph)

Can you try to give a more descriptive name than add?


More information about the webkit-reviews mailing list