[webkit-reviews] review denied: [Bug 62422] TiledBackingStore endlessly creates and destroys tiles due to an off-by-one error. : [Attachment 96723] patch

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at nokia.com> has denied Hwang
<luxtella at company100.net>'s request for review:
Bug 62422: TiledBackingStore endlessly creates and destroys tiles due to an
off-by-one error.
https://bugs.webkit.org/show_bug.cgi?id=62422

Attachment 96723: patch
https://bugs.webkit.org/attachment.cgi?id=96723&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=96723&action=review

> Source/WebCore/ChangeLog:9
> +	   REGRESSION(410d71df): Fix Qt bustage.

Please use SVN revision numbers, I guess you meant r77312.

Please also say why it broke, that bottomRight used to do this - 1 correction
itself and that it was replaced everywhere by maxX/Y, which doesn't anymore.
I wonder, though, how this can be the only thing that broke, I don't
understand.

> Source/WebKit2/ChangeLog:9
> +	   REGRESSION(410d71df): Fix Qt bustage.

Same.


Otherwise looks fine, thanks for catching this!