[webkit-reviews] review granted: [Bug 62445] [EFL][WK2] Add dummy files at below of WebProcess. : [Attachment 96725] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Ryuan Choi
<ryuan.choi at samsung.com>'s request for review:
Bug 62445: [EFL][WK2] Add dummy files at below of WebProcess.
https://bugs.webkit.org/show_bug.cgi?id=62445

Attachment 96725: Patch
https://bugs.webkit.org/attachment.cgi?id=96725&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96725&action=review

> Source/WebKit2/WebProcess/Cookies/efl/WebCookieManagerEfl.cpp:33
> +    // FIXME: Not implemented.

why not use notImplemented() ? please do that

> Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:42
> +    ASSERT(argc == 2);

Why not handle it instead