[webkit-reviews] review granted: [Bug 61925] Add layer factory to GraphicsLayer for creating non-default layer type. : [Attachment 96693] Patch based on smfr's comments
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 10 01:37:59 PDT 2011
Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 61925: Add layer factory to GraphicsLayer for creating non-default layer
type.
https://bugs.webkit.org/show_bug.cgi?id=61925
Attachment 96693: Patch based on smfr's comments
https://bugs.webkit.org/attachment.cgi?id=96693&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96693&action=review
> Source/WebCore/platform/graphics/GraphicsLayer.h:372
> + typedef PassOwnPtr<GraphicsLayer>
GraphicsLayerFactory(GraphicsLayerClient*);
> + static void setGraphicsLayerFactory(GraphicsLayerFactory);
We need a comment here explaining what it is for as that is not totally obvious
- at least to me.
More information about the webkit-reviews
mailing list