[webkit-reviews] review granted: [Bug 62406] [chromium] Printing does not work for accelerated <canvas> : [Attachment 96677] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 62406: [chromium] Printing does not work for accelerated <canvas>
https://bugs.webkit.org/show_bug.cgi?id=62406

Attachment 96677: Patch
https://bugs.webkit.org/attachment.cgi?id=96677&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96677&action=review

R=me

> Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp:139
> +    if (!bitmap.getPixels()) {

can you leave some sort of comment indicating when getPixels() returns NULL and
why we gotta do a readPixels() when it does?