[webkit-reviews] review requested: [Bug 62380] [EFL] correct sharedTimer value in SharedTimerEfl.cpp : [Attachment 96646] remove _sharedTimer = 0 in timerEvent()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 9 14:36:57 PDT 2011

Henry Song <hsong at sisa.samsung.com> has asked  for review:
Bug 62380: [EFL] correct sharedTimer value in SharedTimerEfl.cpp

Attachment 96646: remove _sharedTimer = 0 in timerEvent()

------- Additional Comments from Henry Song <hsong at sisa.samsung.com>
Both stopSharedTimer() and addNewTimer() can be called within timerFunction()
in timerEvent().  If addNewTimer() is called, the static _sharedTimer object is
replaced with new timer object.  If set it to 0 after timerFunction() returns,
the new timer object is lost and cannot be deleted in later stopSharedTimer(). 
This is similar to how it is implemented in SharedTimerGtk.cpp for GTK port.

More information about the webkit-reviews mailing list