[webkit-reviews] review granted: [Bug 62387] Simplify ComplexTextController::collectComplexTextRuns() : [Attachment 96614] Always iterate the characters in logical order

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted mitz at webkit.org's request for review:
Bug 62387: Simplify ComplexTextController::collectComplexTextRuns()
https://bugs.webkit.org/show_bug.cgi?id=62387

Attachment 96614: Always iterate the characters in logical order
https://bugs.webkit.org/attachment.cgi?id=96614&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=96614&action=review

> Source/WebCore/platform/graphics/mac/ComplexTextController.cpp:253
> +	   size_t runCount = m_complexTextRuns.size();
> +	   for (size_t i = 0; i < runCount / 2; ++i)
> +	       swap(m_complexTextRuns[i], m_complexTextRuns[runCount - i - 1]);


I’d like to see this “reverse” algorithm separated out into a function or
function template. I could even imagine putting it into <wtf/Vector.h>.