[webkit-reviews] review requested: [Bug 60059] AssociatedURLLoader reports some errors synchronously : [Attachment 96599] Proposed Patch

[bugzilla-daemon at webkit.org]

Bill Budge <bbudge at gmail.com> has asked  for review:
Bug 60059: AssociatedURLLoader reports some errors synchronously
https://bugs.webkit.org/show_bug.cgi?id=60059

Attachment 96599: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=96599&action=review

------- Additional Comments from Bill Budge <bbudge at gmail.com>
ASSERT_UNUSED didn't compile for me:

    ASSERT_UNUSED(timer == &m_errorTimer, timer);


Source/WebKit/chromium/src/AssociatedURLLoader.cpp: In member function 'void
WebKit::AssociatedURLLoader::ClientAdapter::notifyError(WebCore::Timer<WebKit::
AssociatedURLLoader::ClientAdapter>*)':
Source/WebKit/chromium/src/AssociatedURLLoader.cpp:191: error: void value not
ignored as it ought to be
make: ***
[out/Release/obj.target/webkit/Source/WebKit/chromium/src/AssociatedURLLoader.o
] Error 1

I grepped for other usages and didn't find any in Source/WebKit/chromium.