[webkit-reviews] review requested: [Bug 62366] [GTK] Support authentication dialogs in WebKit2 : [Attachment 96570] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 9 03:56:13 PDT 2011


Carlos Garcia Campos <cgarcia at igalia.com> has asked  for review:
Bug 62366: [GTK] Support authentication dialogs in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=62366

Attachment 96570: Patch
https://bugs.webkit.org/attachment.cgi?id=96570&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
This patch moves the common code to show an auth dialog from
webkitsoupauthdialog to a new C++ class in WebCore. In WebKit1
webkitsoupauthdialog has been converted into a C++ file with the same
interface, since it's public in the api, and it simply contains the soup
feature interface implementation using the new GtkAuthenticationDialog class.
In WebKit2 I added the soup feature interface impemlentation to
WebProcess/gtk/WebProcessMainGtk.cpp since it's very simple, but I can move it
into its own file if you think it's better.


More information about the webkit-reviews mailing list