[webkit-reviews] review granted: [Bug 60059] AssociatedURLLoader reports some errors synchronously : [Attachment 96517] Proposed Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Bill Budge <bbudge at gmail.com>'s
request for review:
Bug 60059: AssociatedURLLoader reports some errors synchronously
https://bugs.webkit.org/show_bug.cgi?id=60059

Attachment 96517: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=96517&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96517&action=review

Thanks for writing the test.  I appreciate it.	One nit below and this looks
good to go.

> Source/WebKit/chromium/src/AssociatedURLLoader.cpp:191
> +    ASSERT(timer);

Normally, we do the following:

ASSERT_UNUSED(timer == &m_errorTimer, timer);

Some configurations of WebKit generate compile errors for unused variables.  In
your patch |timer| is unused in release builds.  Also, the ASSERT above is more
precise because it makes sure |timer| points to the object we expect.