[webkit-reviews] review requested: [Bug 53627] Inspector highlight rect is wrong for contents of transformed iframes : [Attachment 96535] [PATCH] First Attempt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 8 20:20:53 PDT 2011


Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 53627: Inspector highlight rect is wrong for contents of transformed
iframes
https://bugs.webkit.org/show_bug.cgi?id=53627

Attachment 96535: [PATCH] First Attempt
https://bugs.webkit.org/attachment.cgi?id=96535&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
I did not add a layout test. I don't think there are tests for node
highlighting.
I did a quick search in LayoutTests/inspector and saw tests for syntax
highlighting related things.

This worked as expected on my tests cases and the original test page
<http://2011.beercamp.com/>. But this is by no means an area where
I am an expert, and I'm guessing that there is already a way to do what
it is I want to do but I could not find. So I'm going to put up a patch
that people can actually see what I intend.


More information about the webkit-reviews mailing list