[webkit-reviews] review granted: [Bug 62332] [WKView _setDragImage:at:linkDrag:] can crash if WKView is dealloc'ed during drag : [Attachment 96492] Patch to retain self during this method

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted John Sullivan <sullivan at apple.com>'s
request for review:
Bug 62332: [WKView _setDragImage:at:linkDrag:] can crash if WKView is
dealloc'ed during drag
https://bugs.webkit.org/show_bug.cgi?id=62332

Attachment 96492: Patch to retain self during this method
https://bugs.webkit.org/attachment.cgi?id=96492&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=96492&action=review

> Source/WebKit2/UIProcess/API/mac/WKView.mm:2342
> +    RetainPtr<WKView> protect(self);

It’s better to use a noun for the name of the local variable. Say, protector,
instead of protect.