[webkit-reviews] review denied: [Bug 62330] [Qt] JSC Bridge: convert QtConnectionObject to use JSC API : [Attachment 96488] Patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Caio Marcelo de Oliveira Filho
<cmarcelo at webkit.org>'s request for review:
Bug 62330: [Qt] JSC Bridge: convert QtConnectionObject to use JSC API
https://bugs.webkit.org/show_bug.cgi?id=62330

Attachment 96488: Patch
https://bugs.webkit.org/attachment.cgi?id=96488&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=96488&action=review

> Source/WebCore/bridge/qt/qt_runtime.h:224
> +    JSObjectRef m_receiver;
> +    JSObjectRef m_receiverFunction;

These used to be protected, and now they aren't -- you probably want to
gcProtect/Unprotect these if you want to maintain the same semantics as those
that already exist