[webkit-reviews] review granted: [Bug 62327] Add faster lookup cache for multi character identifiers : [Attachment 96481] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 8 14:31:30 PDT 2011


Geoffrey Garen <ggaren at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 62327: Add faster lookup cache for multi character identifiers
https://bugs.webkit.org/show_bug.cgi?id=62327

Attachment 96481: Patch
https://bugs.webkit.org/attachment.cgi?id=96481&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=96481&action=review

r=me

> Source/JavaScriptCore/parser/ParserArena.h:82
> +	   if (ident && ident->length() == (int)length && (!memcmp(characters,
ident->characters(), length * sizeof(UChar))))

static_cast<int>, please.


More information about the webkit-reviews mailing list