[webkit-reviews] review denied: [Bug 62313] RenderEmbeddedObject::getReplacementTextGeometry : [Attachment 96472] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 8 14:08:42 PDT 2011


Eric Seidel <eric at webkit.org> has denied Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 62313: RenderEmbeddedObject::getReplacementTextGeometry
https://bugs.webkit.org/show_bug.cgi?id=62313

Attachment 96472: Patch
https://bugs.webkit.org/attachment.cgi?id=96472&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96472&action=review

> Source/WebCore/platform/graphics/FloatRect.h:110
> +    void moveBy(const IntPoint& delta) { m_location.move(delta.x(),
delta.y()); }

This should be FloatPoint, no?


More information about the webkit-reviews mailing list