[webkit-reviews] review denied: [Bug 62213] Create local CG context for Mac UI elements when Skia is renderer : [Attachment 96412] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Cary Clark <caryclark at google.com>'s
request for review:
Bug 62213: Create local CG context for Mac UI elements when Skia is renderer
https://bugs.webkit.org/show_bug.cgi?id=62213

Attachment 96412: Patch
https://bugs.webkit.org/attachment.cgi?id=96412&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96412&action=review

>> Source/WebCore/platform/mac/LocalCurrentGraphicsContext.mm:64

> 
> Capital and period.  It more than just updates the state, it creates a new
CGContext, doesn't it?	It of course owns the CGContext.
> 
> I'm trying to convey two points here.  1.  that there is a large cost to
calling bitlocker::cgContext, and 2. that callers don't need to own the
pointer.

We could split these out into two methods.  one ensureCGContext() which creates
a new one.  and cgContext() which just gives you access.

right now with cgContext() doing both, things are very confusing.

We could also make it so that there is only ever one cgContext per bitlocker,
and if you need to create a new one, you create a new bitlocker.  BUt the
current system is too confusing to use, as demonstrated by this patch and my
continued confusion. :(