[webkit-reviews] review granted: [Bug 62196] Allow drawing a slider thumb for any nodes : [Attachment 96371] Patch 2

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 62196: Allow drawing a slider thumb for any nodes
https://bugs.webkit.org/show_bug.cgi?id=62196

Attachment 96371: Patch 2
https://bugs.webkit.org/attachment.cgi?id=96371&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96371&action=review

This looks pretty cool.

> Source/WebCore/dom/Node.cpp:966
> +Node* Node::focusCheckDelegationNode()

I think this name is a bit confusing. How about "focusDelegate"?

Also, how does this correlate with the work that Ito-san is doing on focus in
shadow DOM?

> Source/WebCore/html/shadow/SliderThumbElement.h:-52
> -    bool inDragMode() const { return m_inDragMode; }

Whoo, this is cool!