[webkit-reviews] review canceled: [Bug 62114] "WebCore/css/makeprop.pl" and "WebCore/css/makevalues.pl" should take ENABLE_ flags into account : [Attachment 96218] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 8 02:19:50 PDT 2011


Chiculita Alexandru <achicu at adobe.com> has canceled Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 62114: "WebCore/css/makeprop.pl" and "WebCore/css/makevalues.pl" should
take ENABLE_ flags into account
https://bugs.webkit.org/show_bug.cgi?id=62114

Attachment 96218: Patch
https://bugs.webkit.org/attachment.cgi?id=96218&action=review

------- Additional Comments from Chiculita Alexandru <achicu at adobe.com>
Removed "require ../bindings/script" from perl files, and added perl
-Ibindings/script flag instead.

Used C++ preprocessor. The same approach is used by .idl files and other .in
files. That required changing the commenting style from "#" to "//".


More information about the webkit-reviews mailing list