[webkit-reviews] review granted: [Bug 61857] Value of a range input does not update visually when using setAttribute : [Attachment 96392] new patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 61857: Value of a range input does not update visually when using
setAttribute
https://bugs.webkit.org/show_bug.cgi?id=61857

Attachment 96392: new patch
https://bugs.webkit.org/attachment.cgi?id=96392&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96392&action=review

> LayoutTests/fast/forms/range-set-attribute.html:24
> +// rewriting the value attribute should update the value
> +input.setAttribute('value', '20');
> +shouldBe('input.value', '"20"');

You had better print this with debug() for test result readability, or
show what is happening by shouldBe('input.setAttribute("value", "20");
input.value', '"20"');

> LayoutTests/fast/forms/range-set-attribute.html:26
> +// changing the max should effect value

ditto.

> LayoutTests/fast/forms/range-set-attribute.html:30
> +// value attribute should not change the value after you set a value

ditto.