[webkit-reviews] review requested: [Bug 61324] --webkit-visual-word does not work well in words separated by multiple spaces : [Attachment 96330] patch w/ layout test

[bugzilla-daemon at webkit.org]

Xiaomei Ji <xji at chromium.org> has asked  for review:
Bug 61324: --webkit-visual-word does not work well in words separated by
multiple spaces
https://bugs.webkit.org/show_bug.cgi?id=61324

Attachment 96330: patch w/ layout test
https://bugs.webkit.org/attachment.cgi?id=96330&action=review

------- Additional Comments from Xiaomei Ji <xji at chromium.org>
(In reply to comment #14)
> (From update of attachment 96316 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=96316&action=review
> 
> > Source/WebCore/ChangeLog:17
> > +	     wrong for words separated by multiple spaces. For example, given
words A and B separated by 
> 
> You should probably state why it's wrong.

I used an example to explain since I feel it is not easy to explain without an
example.

> 
> > Source/WebCore/ChangeLog:20
> > +	     position after current word. But positionBeforeNextWord and
positionAfterPreviousWord only 
> > +	     take care of case "A|".
> 
> Instead of what positionBeforeNextWord can do, you should state what it gets
wrong.

How about?

 For example, given words A and B separated by
	3 continuous spaces "A	 B", position "A|", "A |", and "A  |" should
all be considered as
	position after current word. But for position "A |", its
previousWordPosition's
	nextWordPosition is position "A|", which is different from its current
position, so the
	current position is not considered as a position after current word,
consequently,
	instead of returning the right position as "A	|B",
positionBeforeNextWord returns the
	position before next next word, as "A	B |C". Similar happens for
position "A  |".