[webkit-reviews] review granted: [Bug 62179] webkitpy: add a popen() call to executive : [Attachment 96183] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 62179: webkitpy: add a popen() call to executive
https://bugs.webkit.org/show_bug.cgi?id=62179

Attachment 96183: Patch
https://bugs.webkit.org/attachment.cgi?id=96183&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96183&action=review

I'm OK with this change.  It's more interesting when we see it used.

> Tools/Scripts/webkitpy/common/system/executive.py:107
> +    PIPE = subprocess.PIPE
> +    STDOUT = subprocess.STDOUT

I'm not sure this bit is super useful.	Especially since we don't ahve STDERR
and STDIN there.