[webkit-reviews] review granted: [Bug 62240] DFG JIT - add support for for-loop array initialization : [Attachment 96314] The patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 7 15:41:54 PDT 2011


Sam Weinig <sam at webkit.org> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 62240: DFG JIT - add support for for-loop array initialization
https://bugs.webkit.org/show_bug.cgi?id=62240

Attachment 96314: The patch
https://bugs.webkit.org/attachment.cgi?id=96314&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96314&action=review

> Source/JavaScriptCore/dfg/DFGOperations.cpp:202
> +    // We should only get here if index is outside the existing vector!

The ! is really helping no one.


More information about the webkit-reviews mailing list