[webkit-reviews] review granted: [Bug 62207] [Qt] RenderThemeQt::adjustSliderThumbSize() should not refer to the parent style : [Attachment 96241] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 62207: [Qt] RenderThemeQt::adjustSliderThumbSize() should not refer to the
parent style
https://bugs.webkit.org/show_bug.cgi?id=62207

Attachment 96241: Patch
https://bugs.webkit.org/attachment.cgi?id=96241&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96241&action=review

Thanks for lookin' out for Qt! <3
r=me

> Source/WebCore/ChangeLog:13
> +	   * platform/qt/RenderThemeQt.cpp: Use fixed values to avoid to refer
to o->parent().

to refer -> referring

> Source/WebCore/platform/qt/RenderThemeQt.cpp:1468
> +    // timelineThumbHeight should match to the height property of
-webkit-media-controls-timeline in mediaControlsQt.css.

match to -> match

> Source/WebCore/platform/qt/RenderThemeQt.cpp:1471
> +    // volumeThmbWidth should match to the width property of
-webkit-media-controls-volue-slider in mediaControlsQt.css.

match to -> match
volumeThmbWidth -> volumeThumbWidth
volue -> volume