[webkit-reviews] review denied: [Bug 62222] JSStaticFunction and JSStaticValue are overly "const" : [Attachment 96270] proposed patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied  review:
Bug 62222: JSStaticFunction and JSStaticValue are overly "const"
https://bugs.webkit.org/show_bug.cgi?id=62222

Attachment 96270: proposed patch
https://bugs.webkit.org/attachment.cgi?id=96270&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Oops!

The Windows EWS bot failed to compile, and showing this warning, which
illustrates a real bug in your code:

7>c:\cygwin\home\buildbot\webkit\source\javascriptcore\api\tests\testapi.c(943)
: error C2220: warning treated as error - no 'object' file generated
7>c:\cygwin\home\buildbot\webkit\source\javascriptcore\api\tests\testapi.c(943)
: warning C4700: uninitialized local variable 'fun' used
7>c:\cygwin\home\buildbot\webkit\source\javascriptcore\api\tests\testapi.c(945)
: warning C4700: uninitialized local variable 'val' used

You can't just declare "fun" as a pointer -- you need to point to something.
I'd suggest changing this to declare fun and val as variables on the stack.