[webkit-reviews] review denied: [Bug 61423] [EFL] Eina_List out of memory handling : [Attachment 96247] a new patch

[bugzilla-daemon at webkit.org]

Lucas De Marchi <demarchi at webkit.org> has denied Grzegorz
<g.czajkowski at samsung.com>'s request for review:
Bug 61423: [EFL] Eina_List out of memory handling
https://bugs.webkit.org/show_bug.cgi?id=61423

Attachment 96247: a new patch
https://bugs.webkit.org/attachment.cgi?id=96247&action=review

------- Additional Comments from Lucas De Marchi <demarchi at webkit.org>
OMG! This is ugly as hell! Please, don't do that!


Are you going to test each OOM condition? An interesting reading:
http://rusty.ozlabs.org/?p=186. In this case, the following applies: "Never
think to write malloc-fail-proof code without testing it thoroughly, otherwise
you haven’t written malloc-fail-proof code".

If you really want to debug these situations, the best place to check for them
is inside Eina (since you are talking about eina_list_append), not inside
webkit.


For the reason pointed out above, informal r- on my part.