[webkit-reviews] review denied: [Bug 62178] new-run-webkit-tests: Bot master should print useful information on waterfall/console for nrwt : [Attachment 96291] shortened text further

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 62178: new-run-webkit-tests: Bot master should print useful information on
waterfall/console for nrwt
https://bugs.webkit.org/show_bug.cgi?id=62178

Attachment 96291: shortened text further
https://bugs.webkit.org/attachment.cgi?id=96291&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96291&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:287
> +		   match = expressions[name].match(line)

Nit: Maybe use search() instead of match()?  search() matches anywhere in the
string and match() only matches the beginning of the string.

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:292
> +		   if name not in testFailures:
> +		       testFailures[name] = 0
> +		   testFailures[name] += int(match.group(1))

This could be testFailures[name] = testFailures.get(name, 0) +
int(match.group(1))

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:313
> +	   return SUCCESS

Did you mean to return result here?