[webkit-reviews] review granted: [Bug 59753] Chromium Mac: Fork ScrollAnimatorMac to ScrollAnimatorChromiumMac for overlay scrollbar support : [Attachment 95034] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 7 12:01:19 PDT 2011
Mihai Parparita <mihaip at chromium.org> has granted Sailesh Agrawal
<sail at chromium.org>'s request for review:
Bug 59753: Chromium Mac: Fork ScrollAnimatorMac to ScrollAnimatorChromiumMac
for overlay scrollbar support
https://bugs.webkit.org/show_bug.cgi?id=59753
Attachment 95034: Patch
https://bugs.webkit.org/attachment.cgi?id=95034&action=review
------- Additional Comments from Mihai Parparita <mihaip at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95034&action=review
> Source/WebCore/platform/chromium/ScrollAnimatorChromiumMac.mm:926
> + m_haveScrolledSincePageLoad = true;
Nit: Is this necessary? smoothScrollWithEvent is only called by
handleWheelEvent, and you already set m_haveScrolledSincePageLoad to true
there.
More information about the webkit-reviews
mailing list