[webkit-reviews] review granted: [Bug 62196] Allow drawing a slider thumb in deeper place : [Attachment 96221] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 62196: Allow drawing a slider thumb in deeper place
https://bugs.webkit.org/show_bug.cgi?id=62196

Attachment 96221: Patch
https://bugs.webkit.org/attachment.cgi?id=96221&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96221&action=review

I am not thrilled about adding shadow DOM-related functions to RenderObject. It
seems like an abstraction leak. But I know you're fixing an abstraction leak,
so perhaps this will work out on the long term.

> Source/WebCore/rendering/RenderObject.cpp:248
> +RenderObject* RenderObject::hostRenderer() const

This should probably have a more descriptive name, like
shadowNodeHostRenderer().