[webkit-reviews] review denied: [Bug 62178] new-run-webkit-tests: Bot master should print useful information on waterfall/console for nrwt : [Attachment 96200] shortened text

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 7 09:54:48 PDT 2011


Ojan Vafai <ojan at chromium.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 62178: new-run-webkit-tests: Bot master should print useful information on
waterfall/console for nrwt
https://bugs.webkit.org/show_bug.cgi?id=62178

Attachment 96200: shortened text
https://bugs.webkit.org/attachment.cgi?id=96200&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
I don't think we should print out what kind of failure/flaky it is. Just a sum
number for each of the following:
# failures
# flaky
# unexpected passes

Printing out more is too much information to make sense of. Also, perhaps as a
separate patch, I'd really like to see us printout the first 10 failures as
well like we do on the build.chromium.org waterfall. That really helps a lot in
identifying when a test started failing.


More information about the webkit-reviews mailing list