[webkit-reviews] review canceled: [Bug 49142] Implement HTML5 style scoped attribute : [Attachment 96223] work-in-progress

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 7 09:15:20 PDT 2011


Dimitri Glazkov (Google) <dglazkov at chromium.org> has canceled Roland Steiner
<rolandsteiner at chromium.org>'s request for review:
Bug 49142: Implement HTML5 style scoped attribute
https://bugs.webkit.org/show_bug.cgi?id=49142

Attachment 96223: work-in-progress
https://bugs.webkit.org/attachment.cgi?id=96223&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96223&action=review

> Source/WebCore/css/CSSStyleSelector.cpp:325
> +typedef Vector<RuleData> RulesVector;

Avoid cleanups in non-trivial patches. Makes for very painful archeology.

> Source/WebCore/dom/ElementRareData.h:90
> +    ++m_numberOfScopedHTMLStyleChildren;

I don't think this is necessary.


More information about the webkit-reviews mailing list