[webkit-reviews] review denied: [Bug 48578] HTML5 Conformance Test failure: approved/canvas/canvas_text_font_001.htm : [Attachment 96217] Incorporating Eric & Kling's comment

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Mustafizur Rahaman
<mustaf.here at gmail.com>'s request for review:
Bug 48578: HTML5 Conformance Test failure:
approved/canvas/canvas_text_font_001.htm
https://bugs.webkit.org/show_bug.cgi?id=48578

Attachment 96217: Incorporating Eric & Kling's comment
https://bugs.webkit.org/attachment.cgi?id=96217&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I don't understand why we need to remove/append to substrings for your
algorithm to work.

Isn't it just:

while (start < end) {
  if (isSpaceOrNewLine(*start))
     continue;
   bool equalIgnoringCase(start, "inherit") || equalIgnoringCase(start,
"initial") {
      start += 6;
      if (start == end || isSpaceOrNewline(start))
	  return true;
   }
}

That's not quite real code because I'm not updating start quite correctly.  But
that's the idea.

If we don't have an elegant way to write this, I'm not sure it should be
written.  This is a very low-priority fix.
}