[webkit-reviews] review requested: [Bug 32509] Composition input method lacks character echo in password input fields : [Attachment 96239] fix patch 3: rebaseline + minor changes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 7 08:32:41 PDT 2011


Chang Shu <cshu at webkit.org> has asked  for review:
Bug 32509: Composition input method lacks character echo in password input
fields
https://bugs.webkit.org/show_bug.cgi?id=32509

Attachment 96239: fix patch 3: rebaseline + minor changes
https://bugs.webkit.org/attachment.cgi?id=96239&action=review

------- Additional Comments from Chang Shu <cshu at webkit.org>
>> fix patch 3: rebaseline + minor changes
> Plans to put it up for revieW?

Ok, why not give it a shot? :)
In the new patch, I removed the change in JavascriptCore so it doesn't have to
depend on the cleanup of String::makeSecure.
In terms of WebKit vs. WebCore approach, I think the latter provides a
cross-platform solution which will benefit all ports.


More information about the webkit-reviews mailing list