[webkit-reviews] review denied: [Bug 61776] text-shadow disappears if CSS uses ::selection { text-shadow: none } on a @font-face font : [Attachment 96201] Patch V1

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 61776: text-shadow disappears if CSS uses ::selection { text-shadow: none }
on a @font-face font
https://bugs.webkit.org/show_bug.cgi?id=61776

Attachment 96201: Patch V1
https://bugs.webkit.org/attachment.cgi?id=96201&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=96201&action=review

> LayoutTests/fast/repaint/text-shadow-selection.html:13
> +.textshadow {
> +  text-shadow: 10px 0px red;
> +  font-family: sans-serif;
> +  font-size: 36pt;
> +  font-weight: bold;
> +}
> +::selection {
> +  background: #ccc;
> +  text-shadow: none;
> +}

There is no @font-face in this testcase, so is the bug title no longer
accurate?

> Source/WebCore/editing/FrameSelection.cpp:1218
> +	      
view->repaintRectangleInViewAndCompositedLayers(oldAbsoluteCaretRepaintBounds,
false);
>	      
view->repaintRectangleInViewAndCompositedLayers(m_absoluteCaretRepaintBounds,
false);

This change doesn't seem right. An extra invalidate via
repaintRectangleInViewAndCompositedLayers() should not cause repaint failure,
only extra work. By making this change, you're opening up the possibility that
we'll leave stale images of the caret around.