[webkit-reviews] review denied: [Bug 62206] Web Inspector: remove duplicate breakpoints from localStorage : [Attachment 96236] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 7 07:44:54 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has denied Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 62206: Web Inspector: remove duplicate breakpoints from localStorage
https://bugs.webkit.org/show_bug.cgi?id=62206

Attachment 96236: Patch
https://bugs.webkit.org/attachment.cgi?id=96236&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96236&action=review

> Source/WebCore/inspector/front-end/Settings.js:127
> +		   var start = s.indexOf("{", i);

Seems like a weak assumption. Should we nuke it altogether?


More information about the webkit-reviews mailing list