[webkit-reviews] review granted: [Bug 60205] Media Stream API: integrate the Track List objects into the existing code : [Attachment 95421] Patch

[bugzilla-daemon at webkit.org]

Tony Gentilcore <tonyg at chromium.org> has granted Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 60205: Media Stream API: integrate the Track List objects into the existing
code
https://bugs.webkit.org/show_bug.cgi?id=60205

Attachment 95421: Patch
https://bugs.webkit.org/attachment.cgi?id=95421&action=review

------- Additional Comments from Tony Gentilcore <tonyg at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95421&action=review

Just a nit and a question, everything else looks good to me.

> Source/WebCore/dom/ExclusiveTrackList.cpp:73
> +void ExclusiveTrackList::trackFailed(unsigned long index)

It isn't obvious to me why mediaStreamFrameController doesn't need to be
notified.

> Source/WebCore/dom/TrackList.cpp:167
>      // For the HTML Media Element:
https://bugs.webkit.org/show_bug.cgi?id=61127

This comment has a redundant "for the HTML Media Element" now.