[webkit-reviews] review denied: [Bug 62128] [Qt][V8] DumpRenderTree causes assertion in V8 : [Attachment 96095] proposed patch

[bugzilla-daemon at webkit.org]

Jędrzej Nowacki <jedrzej.nowacki at nokia.com> has denied Peter Varga
<pvarga at webkit.org>'s request for review:
Bug 62128: [Qt][V8] DumpRenderTree causes assertion in V8
https://bugs.webkit.org/show_bug.cgi?id=62128

Attachment 96095: proposed patch
https://bugs.webkit.org/attachment.cgi?id=96095&action=review

------- Additional Comments from Jędrzej Nowacki <jedrzej.nowacki at nokia.com>
The optimization in QtScript is wrong and it should be removed. Assumption that
I made that QtScript is controlling exclusively V8 API is not more valid.

The patch it doesn't solve the real problem here. Still, destruction order of
HandleScopes is wrong if QScriptEngine doesn't contain the topmost HandleScope.
It just happened to work :(.

Please look at description of QSOGO class, I'd love to kill the class. It was
purely created because of missing V8 C++ API, (we are "cheating" on JS side
there :-) ). I do think that we should focus on removing the class instead of
aggressive optimization.