[webkit-reviews] review denied: [Bug 61911] REGRESSION: Page layout messed up after exiting full screen after video ends at jerryseinfeld.com : [Attachment 95941] Patch

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has denied Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 61911: REGRESSION: Page layout messed up after exiting full screen after
video ends at jerryseinfeld.com
https://bugs.webkit.org/show_bug.cgi?id=61911

Attachment 95941: Patch
https://bugs.webkit.org/attachment.cgi?id=95941&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=95941&action=review

r- due to previous comment about additions to the IDL.

>> Source/WebCore/html/HTMLMediaElement.h:210
>> +	int offsetHeight();
> 
> This approach seems pretty fragile. What if we add code elsewhere in
HTMLMediaElement or subclasses that calls offsetLeft etc?

If these are virtual overrides, then this seems ok unless we have code that
specifically needs the "true" offsetLeft/Top/Height/Width. However, I believe
these methods exist almost entirely to implement the relevant JS API. So I
think this is ok.