[webkit-reviews] review granted: [Bug 62164] Remove "multi-threaded" logic in V8 DOMData, DOMDataStore and friends : [Attachment 96189] Updated threading comment in DOMDataStore.cpp

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dmitry Lomov <dslomov at google.com>'s
request for review:
Bug 62164: Remove "multi-threaded" logic in V8 DOMData, DOMDataStore and
friends
https://bugs.webkit.org/show_bug.cgi?id=62164

Attachment 96189: Updated threading comment in DOMDataStore.cpp
https://bugs.webkit.org/attachment.cgi?id=96189&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96189&action=review

This looks great.  There's probably another round of cleanup we can do here,
but we can do that in a subsequent patch.

> Source/WebCore/bindings/v8/DOMData.cpp:74
> +
> +

This diff seem unneeded.

> Source/WebCore/bindings/v8/DOMData.h:54
> -	   virtual DOMDataStore& getStore() = 0;
> +	   DOMDataStore& getStore() { return getMainThreadStore(); }

Now that this function isn't virtual, it seems like we don't need to separate
these calls, right?

> Source/WebCore/bindings/v8/DOMData.h:62
> -	   ThreadIdentifier owningThread() const { return m_owningThread; }
> +	   static DOMDataStore& getCurrentMainThreadStore() { return
getCurrent()->getMainThreadStore(); }

Do we still need the concept of "MainThreadStore" or can we remove all mentions
of that too now?