[webkit-reviews] review denied: [Bug 61413] Make document.activeElement work with shadow content. : [Attachment 95163] Add a guard to document.activeElement

[bugzilla-daemon at webkit.org]

MORITA Hajime <morrita at google.com> has denied Hayato Ito
<hayato at chromium.org>'s request for review:
Bug 61413: Make document.activeElement work with shadow content.
https://bugs.webkit.org/show_bug.cgi?id=61413

Attachment 95163: Add a guard to document.activeElement
https://bugs.webkit.org/attachment.cgi?id=95163&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=95163&action=review

> Source/WebCore/html/HTMLDocument.cpp:142
> +    if (!node) {

Could you split out this loop logic into a static function or Frame method?
nested if-if-for-if looks complicated enough.

> Source/WebCore/html/HTMLDocument.cpp:152
> +    ASSERT(!node || node->document() == this);

I'd like to return early here when node is null.