[webkit-reviews] review denied: [Bug 61324] --webkit-visual-word does not work well in words separated by multiple spaces : [Attachment 95834] patch w/ layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 6 18:10:12 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> has denied Xiaomei Ji <xji at chromium.org>'s
request for review:
Bug 61324: --webkit-visual-word does not work well in words separated by
multiple spaces
https://bugs.webkit.org/show_bug.cgi?id=61324

Attachment 95834: patch w/ layout test
https://bugs.webkit.org/attachment.cgi?id=95834&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95834&action=review

> Source/WebCore/ChangeLog:12
> +	   Remove positionBeforeNextWord and positionAfterPreviousWord
short-cuts, which are not 
> +	   correct for words separated by multiple spaces and words not
separated by space.
> +
> +	   For those cases, we will have to collect all the word breaks inside
the box and look for
> +	   the one at left or right of current position.

Why?  Why was old code wrong?  And how does removing those calls fix the bug? 
I'd to see more explanation.


More information about the webkit-reviews mailing list