[webkit-reviews] review denied: [Bug 62164] Remove "multi-threaded" logic in V8 DOMData, DOMDataStore and friends : [Attachment 96159] CR feedback - more context in ChangeLog

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 6 17:53:30 PDT 2011


Dmitry Titov <dimich at chromium.org> has denied Dmitry Lomov
<dslomov at google.com>'s request for review:
Bug 62164: Remove "multi-threaded" logic in V8 DOMData, DOMDataStore and
friends
https://bugs.webkit.org/show_bug.cgi?id=62164

Attachment 96159: CR feedback - more context in ChangeLog
https://bugs.webkit.org/attachment.cgi?id=96159&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
Adam has inspired me to do a better review :-)

Lets indeed remove all pieces that are not needed anymore:
- Comment in DOMDataStore.cpp, that explains threading considerations should be
updated.
- in V8DOMMap.*, lets rename methods like
'visitActiveDOMObjectsInCurrentThread' to 'visitActiveDOMObjects', since they
are not looking at thread anymore.
- As Adam noted, ChildThreadDOMData can go away - but at the same time
MainThreadDOMData can go away as well, so there is only single DOMData class.


More information about the webkit-reviews mailing list