[webkit-reviews] review denied: [Bug 62164] Remove "multi-threaded" logic in V8 DOMData, DOMDataStore and friends : [Attachment 96147] Removing multithreaded logic
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 6 17:21:12 PDT 2011
Dmitry Titov <dimich at chromium.org> has denied Dmitry Lomov
<dslomov at google.com>'s request for review:
Bug 62164: Remove "multi-threaded" logic in V8 DOMData, DOMDataStore and
friends
https://bugs.webkit.org/show_bug.cgi?id=62164
Attachment 96147: Removing multithreaded logic
https://bugs.webkit.org/attachment.cgi?id=96147&action=review
------- Additional Comments from Dmitry Titov <dimich at chromium.org>
Great patch, since you want to use commit-queue, lets make it perfect: could
you please add a sentence to ChangeLog explaining that this is an old code from
Lockers-based implementation of WebWorkers in V8 bindings, to make sure that
DOM objects are released on the right thread even though GC could have happened
on any thread. It is currently unused (since current model is one worker per
process) and is being removed because new implementation will be using V8
isolates and does not need the DOMStores per thread.
Just to give it more context...
More information about the webkit-reviews
mailing list