[webkit-reviews] review denied: [Bug 62069] Make FileInputType a FileChooserClient. : [Attachment 96128] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 62069: Make FileInputType a FileChooserClient.
https://bugs.webkit.org/show_bug.cgi?id=62069

Attachment 96128: Patch
https://bugs.webkit.org/attachment.cgi?id=96128&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96128&action=review

> Source/WebCore/html/FileInputType.cpp:309
> +    element()->dispatchFormControlChangeEvent();
> + 
> +    repaint();

dispatchFormControlChangeEvent() dispatches a synchronous event, a JavaScript
code might run in an event handler, and it might change the type of the
<input>.
So this FileInputType might be deleted after dispatchFromControlChangeEvent(). 
We should not call repaint().