[webkit-reviews] review granted: [Bug 62156] Switch InlineFlowBox::paintMask to use IntPoint : [Attachment 96138] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 6 15:23:25 PDT 2011


Eric Seidel <eric at webkit.org> has granted Levi Weintraub <leviw at chromium.org>'s
request for review:
Bug 62156: Switch InlineFlowBox::paintMask to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62156

Attachment 96138: Patch
https://bugs.webkit.org/attachment.cgi?id=96138&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96138&action=review

> Source/WebCore/rendering/InlineFlowBox.cpp:1223
> +	   int stripX = adjustedPaintOffset.x() - (isHorizontal() ?
logicalOffsetOnLine : 0);
> +	   int stripY = adjustedPaintOffset.y() - (isHorizontal() ? 0 :
logicalOffsetOnLine);
>	   int stripWidth = isHorizontal() ? totalLogicalWidth :
frameRect.width();
>	   int stripHeight = isHorizontal() ? frameRect.height() :
totalLogicalWidth;

I suspect we can clean this up more in a later pass.


More information about the webkit-reviews mailing list