[webkit-reviews] review denied: [Bug 62130] Convert RenderBox::absoluteRects to IntPoint : [Attachment 96113] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 62130: Convert RenderBox::absoluteRects to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62130

Attachment 96113: Patch
https://bugs.webkit.org/attachment.cgi?id=96113&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96113&action=review

> Source/WebCore/dom/Node.cpp:842
> -    renderer()->absoluteRects(rects, absPos.x(), absPos.y());
> +    renderer()->absoluteRects(rects, flooredIntPoint(absPos));

Confused.  Is that what the old behavior did?

> Source/WebCore/rendering/RenderBlock.cpp:5692
> +	   continuation()->absoluteRects(rects, accumulatedOffset -
toSize(location() +
> +		  
inlineElementContinuation()->containingBlock()->location()));

I might have broken this out into a local IntPOint variable.  But looks fine.

> Source/WebCore/rendering/RenderInline.cpp:474
> +	       rects.append(enclosingIntRect(FloatRect(accumulatedOffset +
IntSize(curr->x(), curr->y()), IntSize(curr->width(), curr->height()))));

curr->location()?  curr->size()?

> Source/WebCore/rendering/RenderText.cpp:275
> +	   rects.append(enclosingIntRect(FloatRect(accumulatedOffset +
IntSize(box->x(), box->y()), IntSize(box->x(), box->y()))));

you meant box width/height.