[webkit-reviews] review granted: [Bug 62137] Switch paintOutline, paintContinuationOutlines, and paintOutlineForLine to use IntPoint : [Attachment 96107] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Levi Weintraub <leviw at chromium.org>'s
request for review:
Bug 62137: Switch paintOutline, paintContinuationOutlines, and
paintOutlineForLine to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62137

Attachment 96107: Patch
https://bugs.webkit.org/attachment.cgi?id=96107&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96107&action=review

> Source/WebCore/rendering/RenderBlock.cpp:2681
> +	   for ( ; block && block != this; block = block->containingBlock())
> +	       accumulatedPaintOffset.move(block->location());

Really?  We don't have a function to accumulate these for us?  We should as
smfr if this is the modern way to do this.  I suspect there may be a bug here.

> Source/WebCore/rendering/RenderInline.cpp:1503
> +		      (!nextline.isEmpty() && l - ow < paintOffset.x() +
nextline.maxX()) ? -ow : ow,

Obviously there is a bunch of cleanup we could do to this function in a second
pass.