[webkit-reviews] review denied: [Bug 61207] [Qt] Export files under Symbian Qt WebKit build : [Attachment 94681] Export headers files to the bld.inf files for the Symbian build

[bugzilla-daemon at webkit.org]

Laszlo Gombos <laszlo.1.gombos at nokia.com> has denied Joe Wild
<joseph.wild at nokia.com>'s request for review:
Bug 61207: [Qt] Export files under Symbian Qt WebKit build
https://bugs.webkit.org/show_bug.cgi?id=61207

Attachment 94681: Export headers files to the bld.inf files for the Symbian
build
https://bugs.webkit.org/attachment.cgi?id=94681&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=94681&action=review

r- because of the change in WebKit.pri. Janne's proposal seems to be a
"cleaner" way to do address this issue, so we should understand better why
Janne's proposal would not work before we proceed with this approach.

>> Source/WebKit.pri:27
>> +isEmpty(OUTPUT_DIR): OUTPUT_DIR = $$PWD
> 
> Why is this needed in the .pri file?
> 
> I thought it belongs into the .pro files, and QtWebKit.pro has it indeed.

I agree that this needs to be removed; so will r- for now.